Migrate AddCustomConstructorOperation.run() from SubProgressMonitor to SubMonitor#2989
Open
vogella wants to merge 1 commit into
Open
Migrate AddCustomConstructorOperation.run() from SubProgressMonitor to SubMonitor#2989vogella wants to merge 1 commit into
vogella wants to merge 1 commit into
Conversation
…o SubMonitor Replace beginTask/setTaskName/Progress.subMonitor with a single SubMonitor.convert() at the method entry followed by split() calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the deprecated
SubProgressMonitorpattern inrun()with the modernSubMonitorAPI. The method previously calledbeginTask()andsetTaskName()separately on the raw monitor and then passed that same monitor toProgress.subMonitor(), which internally callsSubMonitor.convert()and triggers a secondbeginTask()on the same monitor. The fix replaces both calls with a singleSubMonitor.convert()at the entry point (passing the task name directly) and usessplit()for each unit of work. The unusedProgressimport is removed.